From d32dbe37fef7f79e9115e24a6ac7a38bdf48bbbe Mon Sep 17 00:00:00 2001 From: Thomas Schmitt Date: Wed, 28 Oct 2015 19:22:34 +0000 Subject: [PATCH] Prevented a quite unlikely buffer overflow by argument. Coverity CID 21827. --- cdrskin/cdrskin.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cdrskin/cdrskin.c b/cdrskin/cdrskin.c index 4a76469..f00a2d5 100644 --- a/cdrskin/cdrskin.c +++ b/cdrskin/cdrskin.c @@ -3103,6 +3103,12 @@ see_cdrskin_eng_html:; o->abort_handler= 2; } else if(strncmp(argv[i],"fallback_program=",17)==0) { + if(strlen(argv[i] + 17) >= sizeof(o->fallback_program)) { + fprintf(stderr, + "cdrskin: FATAL : fallback_program=... too long (max. %d characters)\n", + (int) sizeof(o->fallback_program) - 1); + {ret= 0; goto ex;} + } strcpy(o->fallback_program,argv[i]+17); } else if(strcmp(argv[i],"--no_abort_handler")==0) {