From 84c3e88eb34a6e69c54a6bca40aebc04645683cb Mon Sep 17 00:00:00 2001 From: Thomas Schmitt Date: Fri, 13 Nov 2015 20:22:51 +0000 Subject: [PATCH] Handled failure to release a mutex lock. Coverity CID 28698. --- xorriso/drive_mgt.c | 9 ++++++--- xorriso/xorriso_timestamp.h | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/xorriso/drive_mgt.c b/xorriso/drive_mgt.c index 7ec7df37..07d2e9e8 100644 --- a/xorriso/drive_mgt.c +++ b/xorriso/drive_mgt.c @@ -2394,7 +2394,7 @@ struct xorriso_md5_state { int Xorriso__add_spot(struct xorriso_md5_state *state, int start_lba, int blocks, int quality, int flag) { - int ret; + int ret, uret; if(state->chunk != NULL) { ret= pthread_mutex_lock(&(state->spot_mutex)); @@ -2402,8 +2402,11 @@ int Xorriso__add_spot(struct xorriso_md5_state *state, return(0); } ret= Spotlist_add_item(state->spotlist, start_lba, blocks, quality, 0); - if(state->chunk != NULL) - pthread_mutex_unlock(&(state->spot_mutex)); + if(state->chunk != NULL) { + uret= pthread_mutex_unlock(&(state->spot_mutex)); + if(uret != 0 && ret > 0) + ret= 0; + } return(ret); } diff --git a/xorriso/xorriso_timestamp.h b/xorriso/xorriso_timestamp.h index d6670bf7..03988e66 100644 --- a/xorriso/xorriso_timestamp.h +++ b/xorriso/xorriso_timestamp.h @@ -1 +1 @@ -#define Xorriso_timestamP "2015.11.13.152751" +#define Xorriso_timestamP "2015.11.13.202241"