libburnia
/
libisoburn
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

unify output, drop completed TODO item

This commit is contained in:
George Danchev 2011-07-07 14:49:48 +00:00
parent 1502f19b6c
commit 90d62adfe7
2 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
releng/TODO
View File

@ -11,18 +11,11 @@
MD5s should be checked. ACLs and xattr (if we are on Linux). MD5s should be checked. ACLs and xattr (if we are on Linux).
All file types as of stat(2) should be tested. All file types as of stat(2) should be tested.
* Also check (in releng_isocontent) simple operations like: * Also check trivial operations like --devices, etc.
xorrisofs foo/ > foo.iso
xorrisofs foo/ -o foo.iso
xorrisofs foo/ | cat > foo.iso
result in producing an ISO image. Verify the result with: * Split off common functionality in common ./lib/ so it can be re-used
'file' by all scripts. This might include cmdline option parsing, some
xorriso -pvd_info validation code like releng_isocontent:is_valid_iso9660
others
Such trivial operations could be separated in another releng_ test
which should also check other trivial operations like --devices, etc.
* We need to give a hint about how much storage space will be consumed. * We need to give a hint about how much storage space will be consumed.

4
releng/releng_isocontent
View File

@ -170,13 +170,13 @@ is_valid_iso9660() {
ISOfile="$1" ISOfile="$1"
if [ ! -f ${ISOfile} ]; then if [ ! -f ${ISOfile} ]; then
failure=1 failure=1
printf "=== FAIL Not found: ${ISOfile}\n" printf "${prog}: FAIL: Not found: ${ISOfile}\n"
fi fi
if file ${ISOfile} | grep -P "ISO\s+9660\s+CD-ROM\s+filesystem\s+data" >/dev/null 2>&1; then if file ${ISOfile} | grep -P "ISO\s+9660\s+CD-ROM\s+filesystem\s+data" >/dev/null 2>&1; then
printf "=== ${ISOfile} OK\n" printf "=== ${ISOfile} OK\n"
else else
failure=1 failure=1
printf "=== FAIL: ${ISOfile} does not look like ISO 9660 filesystem data\n" printf "${prog}: FAIL: ${ISOfile} does not look like ISO 9660 filesystem data\n"
fi fi
} }