libburnia/libisofs
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Ensure names of public tree IsoNodes are valid POSIX names.

Browse Source
This commit is contained in:
Vreixo Formoso 2008-01-08 19:47:33 +01:00
parent aec6c8ce69
commit 1459801134
3 changed files with 65 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
src/node.c
View File

@ -80,37 +80,27 @@ int iso_node_set_name(IsoNode *node, const char *name)
{
char *new;
/* guard against the empty string or big names... */
if (name[0] == '\0' || strlen(name) > 255) {
return ISO_WRONG_ARG_VALUE;
}
/* ...against "." and ".." names... */
if (!strcmp(name, ".") || !strcmp(name, "..")) {
return ISO_WRONG_ARG_VALUE;
}
/* ...and against names with '/' */
if (strchr(name, '/') != NULL) {
return ISO_WRONG_ARG_VALUE;
}
if ((IsoNode*)node->parent == node) {
/* you can't change name of the root node */
return ISO_WRONG_ARG_VALUE;
}
new = strdup(name);
if (new == NULL) {
return ISO_MEM_ERROR;
/* check if the name is valid */
if (!iso_node_is_valid_name(name)) {
return ISO_WRONG_ARG_VALUE;
}
if (node->parent != NULL) {
/* check if parent already has a node with same name */
if (iso_dir_get_node(node->parent, name, NULL) == 1) {
free(new);
return ISO_NODE_NAME_NOT_UNIQUE;
}
}
new = strdup(name);
if (new == NULL) {
return ISO_MEM_ERROR;
}
free(node->name);
node->name = new;
if (node->parent != NULL) {
@ -595,6 +585,36 @@ int iso_file_get_sort_weight(IsoFile *file)
return file->sort_weight;
}
/**
* Check if a given name is valid for an iso node.
*
* @return
* 1 if yes, 0 if not
*/
int iso_node_is_valid_name(const char *name)
{
/* a name can't be NULL */
if (name == NULL) {
return 0;
}
/* guard against the empty string or big names... */
if (name[0] == '\0' || strlen(name) > 255) {
return 0;
}
/* ...against "." and ".." names... */
if (!strcmp(name, ".") || !strcmp(name, "..")) {
return 0;
}
/* ...and against names with '/' */
if (strchr(name, '/') != NULL) {
return 0;
}
return 1;
}
int iso_node_new_root(IsoDir **root)
{
IsoDir *dir;

8
src/node.h
View File

@ -107,4 +107,12 @@ struct Iso_Dir_Iter
int iso_node_new_root(IsoDir **root);
/**
* Check if a given name is valid for an iso node.
*
* @return
* 1 if yes, 0 if not
*/
int iso_node_is_valid_name(const char *name);
#endif /*LIBISO_NODE_H_*/

15
src/tree.c
View File

@ -57,6 +57,11 @@ int iso_tree_add_new_dir(IsoDir *parent, const char *name, IsoDir **dir)
*dir = NULL;
}
/* check if the name is valid */
if (!iso_node_is_valid_name(name)) {
return ISO_WRONG_ARG_VALUE;
}
/* find place where to insert */
pos = &(parent->children);
while (*pos != NULL && strcmp((*pos)->name, name) < 0) {
@ -141,6 +146,11 @@ int iso_tree_add_new_symlink(IsoDir *parent, const char *name,
*link = NULL;
}
/* check if the name is valid */
if (!iso_node_is_valid_name(name)) {
return ISO_WRONG_ARG_VALUE;
}
/* find place where to insert */
pos = &(parent->children);
while (*pos != NULL && strcmp((*pos)->name, name) < 0) {
@ -249,6 +259,11 @@ int iso_tree_add_new_special(IsoDir *parent, const char *name, mode_t mode,
*special = NULL;
}
/* check if the name is valid */
if (!iso_node_is_valid_name(name)) {
return ISO_WRONG_ARG_VALUE;
}
/* find place where to insert */
pos = &(parent->children);
while (*pos != NULL && strcmp((*pos)->name, name) < 0) {