libburnia/libisofs
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Closed memory leak in (improbable) case of error when attaching AAIP

Browse Source 
attributes to IsoNode. Coverity CID 12564.
This commit is contained in:
Thomas Schmitt 2015-10-09 11:03:38 +02:00
parent e5f6811795
commit 83fb614462
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libisofs/node.c
View File

@ -1958,7 +1958,7 @@ int iso_node_set_attrs(IsoNode *node, size_t num_attrs, char **names,
{ {
int ret, acl_saved = 0; int ret, acl_saved = 0;
size_t sret, result_len, m_num = 0, *m_value_lengths = NULL, i; size_t sret, result_len, m_num = 0, *m_value_lengths = NULL, i;
unsigned char *result; unsigned char *result = NULL;
char *a_acl = NULL, *d_acl = NULL, **m_names = NULL, **m_values = NULL; char *a_acl = NULL, *d_acl = NULL, **m_names = NULL, **m_values = NULL;
if (!(flag & 8)) if (!(flag & 8))
@ -2003,8 +2003,11 @@ int iso_node_set_attrs(IsoNode *node, size_t num_attrs, char **names,
} }
ret = iso_node_remove_xinfo(node, aaip_xinfo_func); ret = iso_node_remove_xinfo(node, aaip_xinfo_func);
if (ret < 0) if (ret < 0) {
if (result != NULL)
free(result);
goto ex; goto ex;
}
ret = iso_node_add_xinfo(node, aaip_xinfo_func, result); ret = iso_node_add_xinfo(node, aaip_xinfo_func, result);
if (ret < 0) if (ret < 0)
goto ex; goto ex;