libburnia/libisofs
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Closed a memory leak with loading of hidden boot images

Browse Source
This commit is contained in:
Thomas Schmitt 2014-04-13 11:07:10 +02:00
parent 2f8bd3ac01
commit 8c1c0775d6
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libisofs/fs_image.c
View File

@ -5324,11 +5324,21 @@ int iso_image_import(IsoImage *image, IsoDataSource *src,
} }
ret = image_builder_create_node(image->builder, image, boot_src, ret = image_builder_create_node(image->builder, image, boot_src,
NULL, &node); NULL, &node);
iso_file_source_unref(boot_src); /* Now owned by node */
if (ret < 0) { if (ret < 0) {
iso_node_builder_unref(image->builder); iso_node_builder_unref(image->builder);
goto import_revert; goto import_revert;
} }
image->bootcat->bootimages[idx]->image = (IsoFile*)node; if (image->bootcat->bootimages[idx]->image != NULL) {
/* Already added to bootimages in image_builder_create_node().
* Now it has one refcount for tree and one for bootimages.
* But it will not go to tree. So unref.
*/
iso_node_unref(node);
} else {
image->bootcat->bootimages[idx]->image = (IsoFile*)node;
}
/* warn about hidden images */ /* warn about hidden images */
iso_msg_submit(image->id, ISO_EL_TORITO_HIDDEN, 0, iso_msg_submit(image->id, ISO_EL_TORITO_HIDDEN, 0,