Avoiding to allocate empty buffer for texp packs. Indirectly Coverity CID 21818.

This commit is contained in:
Thomas Schmitt 2015-10-26 10:51:15 +00:00
parent 0957a0e052
commit b3ab9a630f
3 changed files with 11 additions and 2 deletions

View File

@ -1 +1 @@
#define Cdrskin_timestamP "2015.10.26.092929" #define Cdrskin_timestamP "2015.10.26.105324"

View File

@ -1085,6 +1085,7 @@ int burn_cdtext_from_packfile(char *path, unsigned char **text_packs,
BURN_ALLOC_MEM(msg, char, 4096); BURN_ALLOC_MEM(msg, char, 4096);
*text_packs = NULL;
if (stat(path, &stbuf) == -1) { if (stat(path, &stbuf) == -1) {
cannot_open:; cannot_open:;
sprintf(msg, "Cannot open CD-TEXT pack file '%.4000s'", path); sprintf(msg, "Cannot open CD-TEXT pack file '%.4000s'", path);
@ -1136,7 +1137,14 @@ cannot_read:;
path); path);
libdax_msgs_submit(libdax_messenger, -1, 0x0002018b, libdax_msgs_submit(libdax_messenger, -1, 0x0002018b,
LIBDAX_MSGS_SEV_FAILURE, LIBDAX_MSGS_PRIO_HIGH, LIBDAX_MSGS_SEV_FAILURE, LIBDAX_MSGS_PRIO_HIGH,
burn_printify(msg), errno, 0); burn_printify(msg), 0, 0);
ret = 0; goto ex;
} if (*num_packs <= 0) {
strcpy(msg,
"CD-Text pack file contains no complete text pack");
libdax_msgs_submit(libdax_messenger, -1, 0x000201aa,
LIBDAX_MSGS_SEV_FAILURE, LIBDAX_MSGS_PRIO_HIGH,
burn_printify(msg), 0, 0);
ret = 0; goto ex; ret = 0; goto ex;
} }

View File

@ -611,6 +611,7 @@ Range "scdbackup" : 0x00020000 to 0x0002ffff
0x000201a7 (FAILURE,HIGH) = SCSI command yielded host problem 0x000201a7 (FAILURE,HIGH) = SCSI command yielded host problem
0x000201a8 (FAILURE,HIGH) = SCSI command yielded driver problem 0x000201a8 (FAILURE,HIGH) = SCSI command yielded driver problem
0x000201a9 (FAILURE,HIGH) = Implausible length from GET CONFIGURATION 0x000201a9 (FAILURE,HIGH) = Implausible length from GET CONFIGURATION
0x000201aa (FAILURE,HIGH) = No CD-TEXT packs in file
libdax_audioxtr: libdax_audioxtr: