Compare commits

...

2 Commits

9 changed files with 70 additions and 17 deletions
Split View
  1. +6
    -0
      ChangeLog
  2. +7
    -3
      README
  3. +3
    -3
      cdrskin/README
  4. +14
    -1
      cdrskin/cdrfifo.c
  5. +13
    -6
      cdrskin/cdrskin_eng.html
  6. +1
    -1
      cdrskin/cdrskin_timestamp.h
  7. +13
    -0
      cdrskin/changelog.txt
  8. +4
    -3
      configure.ac
  9. +9
    -0
      libburn/sg-linux.c

+ 6
- 0
ChangeLog View File

@@ -1,3 +1,9 @@
libburn-1.5.2.pl01.tar.gz Mon Nov 25 2019
===============================================================================
* Bug fix: cdrskin multi-track burning was slow and stalled after track 1.
Regression introduced in version 1.5.0 by commit 84fad99, 2018.02.05
O_DIRECT is now disabled for track sources.

libburn-1.5.2.tar.gz Sat Oct 26 2019
===============================================================================
* Bug fix: No lock was obtained for setting up a fifo object


+ 7
- 3
README View File

@@ -11,7 +11,7 @@ Still containing parts of Libburn. By Derek Foreman <derek@signalmarketing.com>
and Ben Jansens <xor@orodu.net>
Copyright (C) 2002-2006 Derek Foreman and Ben Jansens

http://files.libburnia-project.org/releases/libburn-1.5.2.tar.gz
http://files.libburnia-project.org/releases/libburn-1.5.2.pl01.tar.gz

------------------------------------------------------------------------------

@@ -19,9 +19,9 @@ Copyright (C) 2002-2006 Derek Foreman and Ben Jansens

From tarball

Obtain libburn-1.5.2.tar.gz, take it to a directory of your choice and do:
Obtain libburn-1.5.2.pl01.tar.gz, take it to a directory of your choice and do:

tar xzf libburn-1.5.2.tar.gz
tar xzf libburn-1.5.2.pl01.tar.gz
cd libburn-1.5.2
./configure --prefix=/usr
make
@@ -791,6 +791,10 @@ Project history as far as known to me:
partitions and the ISO partition.
All three libraries got some rarely triggered bugs fixed.

- Mon Nov 25 2019 patch release 1.5.2.pl01
cdrskin did not properly burn multiple tracks. Track 1 was slow and burning
stalled before track 2. Regression introduced by 1.5.0.

------------------------------------------------------------------------------

This program is free software; you can redistribute it and/or modify


+ 3
- 3
cdrskin/README View File

@@ -4,7 +4,7 @@
cdrskin. By Thomas Schmitt <scdbackup@gmx.net>
Integrated sub project of libburnia-project.org but also published via:
http://scdbackup.sourceforge.net/cdrskin_eng.html
http://scdbackup.sourceforge.net/cdrskin-1.5.2.tar.gz
http://scdbackup.sourceforge.net/cdrskin-1.5.2.pl01.tar.gz

Copyright (C) 2006-2019 Thomas Schmitt, provided under GPL version 2 or later.
------------------------------------------------------------------------------
@@ -26,9 +26,9 @@ By using this software you agree to the disclaimer at the end of this text

Compilation, First Glimpse, Installation

Obtain cdrskin-1.5.2.tar.gz, take it to a directory of your choice and do:
Obtain cdrskin-1.5.2.pl01.tar.gz, take it to a directory of your choice and do:

tar xzf cdrskin-1.5.2.tar.gz
tar xzf cdrskin-1.5.2.pl01.tar.gz
cd cdrskin-1.5.2

Within that directory execute:


+ 14
- 1
cdrskin/cdrfifo.c View File

@@ -28,7 +28,20 @@
#ifndef Cdrfifo_standalonE
/* for burn_os_alloc_buffer() */
#include "../libburn/libburn.h"
#define Libburn_has_open_trac_srC 1

/* ts B91124:
DISABLED, because this spoils multi-track burning by slowing down first
track and stalling before the second track begins. Obviously a problem
with chained input and waiting for full O_DRIECT suitable read chunks.
DO NOT ENABLE before the wait code in this source file is fixed.
That long, ./configure option --enable-track-src-odirect must not
get into effect in libburn. NO -DLibburn_read_o_direcT either.

For extra safety, O_DIRECT has been banned in libburn/sg-linux.c too.

# def ine Libburn_has_open_trac_srC 1
*/

#endif

#include "cdrfifo.h"


+ 13
- 6
cdrskin/cdrskin_eng.html View File

@@ -67,7 +67,7 @@ with drives connected via SCSI, PATA (aka IDE, ATA), USB, or SATA.
GPL software included:<BR>
</H2>
<DL>
<DT>libburn-1.5.2</DT>
<DT>libburn-1.5.2.pl01</DT>
<DD>(founded by Derek Foreman and Ben Jansens,
developed and maintained since August 2006 by
Thomas Schmitt from team of libburnia-project.org)
@@ -202,13 +202,13 @@ Standalone ISO 9660 multi-session CD/DVD/BD tool
<P>
<DL>
<DT>Download as source code (see README):</DT>
<DD><A HREF="cdrskin-1.5.2.tar.gz">cdrskin-1.5.2.tar.gz</A>
<DD><A HREF="cdrskin-1.5.2.pl01.tar.gz">cdrskin-1.5.2.pl01.tar.gz</A>
(1060 KB).
</DD>
<DD><A HREF="cdrskin-1.5.2.tar.gz.sig">cdrskin-1.5.2.tar.gz.sig</A></DD>
<DD><A HREF="cdrskin-1.5.2.pl01.tar.gz.sig">cdrskin-1.5.2.pl01.tar.gz.sig</A></DD>
<DD>
(detached GPG signature for verification by
<KBD>gpg --verify cdrskin-1.5.2.tar.gz.sig cdrskin-1.5.2.tar.gz</KBD>
<KBD>gpg --verify cdrskin-1.5.2.pl01.tar.gz.sig cdrskin-1.5.2.pl01.tar.gz</KBD>
<BR>
after <KBD>gpg --keyserver keys.gnupg.net --recv-keys ABC0A854</KBD>).
</DD>
@@ -280,9 +280,16 @@ Stream recording was applied regardless whether the drive offers it.
This caused Xfburn failures with some MATSHITA laptop drives.
</LI>
</UL>
Bug fixes towards cdrskin-1.5.2 (without .pl01):
<UL>
<LI>
cdrskin multi-track burning was slow and stalled after track 1.
Regression introduced in version 1.5.0 by commit 84fad99, 2018.02.05
</LI>
</UL>
<!--
<LI>none</LI>
Bug fixes towards cdrskin-1.4.2 (without .pl01):
Bug fixes towards cdrskin-1.5.2 (without .pl01):
<UL>
</UL>
-->
@@ -300,7 +307,7 @@ Bug fixes towards cdrskin-1.4.2 (without .pl01):
</UL>
</DD>

<DD>Bug fixes towards cdrskin-1.5.2:
<DD>Bug fixes towards cdrskin-1.5.2.pl01:
<UL>
<LI>none yet</LI>
<!--


+ 1
- 1
cdrskin/cdrskin_timestamp.h View File

@@ -1 +1 @@
#define Cdrskin_timestamP "2019.10.26.143001"
#define Cdrskin_timestamP "2019.11.25.094931"

+ 13
- 0
cdrskin/changelog.txt View File

@@ -13945,6 +13945,19 @@ Committed forgotten header file
* New cdrskin option --list_features


2019.11.25.091234 [91f7d4d]
configure.ac
libburn/sg-linux.c
cdrskin/cdrfifo.c
Bug fix: cdrskin multi-track burning was slow and stalled after track 1.
Regression introduced in version 1.5.0 by commit 84fad99, 2018.02.05

--------------------- bug fix release - cdrskin-1.5.2.pl01 - 2019.11.25.094931
* Bug fix: cdrskin multi-track burning was slow and stalled after track 1.
Regression introduced in version 1.5.0 by commit 84fad99, 2018.02.05
O_DIRECT is now disabled for track sources.


[]
ChangeLog
cdrskin/cdrskin_eng.html


+ 4
- 3
configure.ac View File

@@ -218,11 +218,12 @@ CFLAGS="$STATVFS_DEF $CFLAGS"

dnl ts A91122
AC_ARG_ENABLE(track-src-odirect,
[ --enable-track-src-odirect Enable use of O_DIRECT with track input, default=no],
[ --enable-track-src-odirect Banned for now: (Enable use of O_DIRECT with track input, default=no)],
, enable_track_src_odirect=no)
if test x$enable_track_src_odirect = xyes; then
LIBBURN_O_DIRECT_DEF="-DLibburn_read_o_direcT"
echo "enabled use of O_DIRECT with track input"
# LIBBURN_O_DIRECT_DEF="-DLibburn_read_o_direcT"
# echo "enabled use of O_DIRECT with track input"
echo "REFUSED to enable use of O_DIRECT with track input because of cdrskin multi-track bug"
else
LIBBURN_O_DIRECT_DEF=
echo "disabled use of O_DIRECT with track input"


+ 9
- 0
libburn/sg-linux.c View File

@@ -111,6 +111,15 @@ Hint: You should also look into sg-freebsd-port.c, which is a younger and

/** PORTING : ------- OS dependent headers and definitions ------ */

#ifdef Libburn_read_o_direcT
/* ts B91124:
DISABLED, because this spoils multi-track burning of cdrskin by a hard to
fix bug in cdrskin/cdrfifo.c
DO NOT ENABLE before the wait code in that source file is fixed.
*/
#undef Libburn_read_o_direcT
#endif


#ifdef Libburn_read_o_direcT
# ifndef _GNU_SOURCE


Loading…
Cancel
Save